[PATCH] D61586: [mips] fix segment fault for plt on mips64.

Qiao Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 20:13:22 PDT 2019


QiaoPengcheng marked an inline comment as done.
QiaoPengcheng added a comment.

In D61586#1491724 <https://reviews.llvm.org/D61586#1491724>, @atanasyan wrote:

>




> Please add test case for the patch. Probably we can split the `lld/test/ELF/mips-26-n32-n64.s` into N32 and N64 variants.

How to distinguish between the N32 and N64 abi by llvm-mc  if we split `lld/test/ELF/mips-26-n32-n64.s` into two files ?

Such as my OS-mips64el,  if we split `lld/test/ELF/mips-26-n32-n64.s` into  mips-26-n32.s and mips-26-n64.s ,
we compile the two files using llvm-mc,  they are both N64 becaause there is no args liking -mabi=n32 for llvm-mc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61586/new/

https://reviews.llvm.org/D61586





More information about the llvm-commits mailing list