[PATCH] D61510: [SanitizerCoverage] Use different module ctor names for trace-pc-guard and inline-8bit-counters

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/Instrumentation/SanitizerCoverage/trace-pc-guard-inline-8bit-counters.ll:7
+; CHECK: define internal void @sancov.module_ctor_trace_pc_guard() comdat
+; CHECK: define internal void @sancov.module_ctor_8bit_counters() comdat
+
----------------
morehouse wrote:
> Should we also `CHECK-NOT` for the suffix?
The `.2` suffix is not predictable (well predictable for this small case as we know there is no other duplicate names but probably not good to check the negative pattern).

I'll change it to:
```
- ; CHECK: define internal void @sancov.module_ctor_trace_pc_guard() comdat
- ; CHECK: define internal void @sancov.module_ctor_8bit_counters() comdat
+ ; CHECK: define internal void @sancov.module_ctor_trace_pc_guard() comdat {
+ ; CHECK: define internal void @sancov.module_ctor_8bit_counters() comdat {
```

This ensure the comdat name doesn't take the form of `comdat (sancov.module_ctor.2)` that can cause us trouble.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61510/new/

https://reviews.llvm.org/D61510