[PATCH] D61510: [SanitizerCoverage] Use different module ctor names for trace-pc-guard and inline-8bit-counters

[Matt Morehouse via Phabricator via llvm-commits]

morehouse accepted this revision.
morehouse added inline comments.


================
Comment at: lib/Transforms/Instrumentation/SanitizerCoverage.cpp:289
   std::tie(CtorFunc, std::ignore) = createSanitizerCtorAndInitFunctions(
-      M, SanCovModuleCtorName, InitFunctionName, {Ty, Ty}, {SecStart, SecEnd});
+      M, CtorName, InitFunctionName, {Ty, Ty}, {SecStart, SecEnd});
 
----------------
Can we add an assert that the name of `CtorFunc` matches `CtorName`?


================
Comment at: test/Instrumentation/SanitizerCoverage/trace-pc-guard-inline-8bit-counters.ll:7
+; CHECK: define internal void @sancov.module_ctor_trace_pc_guard() comdat
+; CHECK: define internal void @sancov.module_ctor_8bit_counters() comdat
+
----------------
Should we also `CHECK-NOT` for the suffix?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61510/new/

https://reviews.llvm.org/D61510