[PATCH] D61624: [FastISel][X86] Support FNeg instruction in target independent fast isel handling

[Craig Topper via Phabricator via llvm-commits]

craig.topper created this revision.
craig.topper added reviewers: andrew.w.kaylor, cameron.mcinally, spatel, efriedma.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
craig.topper added a parent revision: D61622: [FastISel][X86] If selectFNeg fails, fall back to SelectionDAG not treating it as an fsub..

This patch adds support for calling selectFNeg for FNeg instructions in addition to the fsub idiom


https://reviews.llvm.org/D61624

Files:
  llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
  llvm/test/CodeGen/X86/fast-isel-fneg.ll


Index: llvm/test/CodeGen/X86/fast-isel-fneg.ll
===================================================================
--- llvm/test/CodeGen/X86/fast-isel-fneg.ll
+++ llvm/test/CodeGen/X86/fast-isel-fneg.ll
@@ -99,3 +99,50 @@
   store float %b, float* %y
   ret void
 }
+
+define double @too(double %x) nounwind {
+; CHECK-LABEL: too:
+; CHECK:       ## %bb.0:
+; CHECK-NEXT:    movq %xmm0, %rax
+; CHECK-NEXT:    movabsq $-9223372036854775808, %rcx ## imm = 0x8000000000000000
+; CHECK-NEXT:    xorq %rax, %rcx
+; CHECK-NEXT:    movq %rcx, %xmm0
+; CHECK-NEXT:    retq
+;
+; SSE2-LABEL: too:
+; SSE2:       # %bb.0:
+; SSE2-NEXT:    pushl %ebp
+; SSE2-NEXT:    movl %esp, %ebp
+; SSE2-NEXT:    andl $-8, %esp
+; SSE2-NEXT:    subl $8, %esp
+; SSE2-NEXT:    movsd {{.*#+}} xmm0 = mem[0],zero
+; SSE2-NEXT:    xorps {{\.LCPI.*}}, %xmm0
+; SSE2-NEXT:    movlps %xmm0, (%esp)
+; SSE2-NEXT:    fldl (%esp)
+; SSE2-NEXT:    movl %ebp, %esp
+; SSE2-NEXT:    popl %ebp
+; SSE2-NEXT:    retl
+  %y = fneg double %x
+  ret double %y
+}
+
+define float @zoo(float %x) nounwind {
+; CHECK-LABEL: zoo:
+; CHECK:       ## %bb.0:
+; CHECK-NEXT:    movd %xmm0, %eax
+; CHECK-NEXT:    xorl $2147483648, %eax ## imm = 0x80000000
+; CHECK-NEXT:    movd %eax, %xmm0
+; CHECK-NEXT:    retq
+;
+; SSE2-LABEL: zoo:
+; SSE2:       # %bb.0:
+; SSE2-NEXT:    pushl %eax
+; SSE2-NEXT:    movss {{.*#+}} xmm0 = mem[0],zero,zero,zero
+; SSE2-NEXT:    xorps {{\.LCPI.*}}, %xmm0
+; SSE2-NEXT:    movss %xmm0, (%esp)
+; SSE2-NEXT:    flds (%esp)
+; SSE2-NEXT:    popl %eax
+; SSE2-NEXT:    retl
+  %y = fneg float %x
+  ret float %y
+}
Index: llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
===================================================================
--- llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
+++ llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
@@ -1839,6 +1839,9 @@
   case Instruction::Xor:
     return selectBinaryOp(I, ISD::XOR);
 
+  case Instruction::FNeg:
+    return selectFNeg(I, I->getOperand(0));
+
   case Instruction::GetElementPtr:
     return selectGetElementPtr(I);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61624.198380.patch
Type: text/x-patch
Size: 2052 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190507/a1ede555/attachment.bin>