[PATCH] D61614: [NFCI] Refactor UnaryOperator class

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 15:16:11 PDT 2019


cameron.mcinally created this revision.
cameron.mcinally added reviewers: spatel, arsenm, kpn, andrew.w.kaylor, craig.topper.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

I had originally placed the UnaryOperator class in `llvm/IR/Instructions.h`, with the other UnaryInstructions. However, I'm now thinking that it makes more sense to live in `llvm/IR/InstrTypes.h`, with BinaryOperator. It is more similar to BinaryOperator than any of the other UnaryInstructions.

It could go either way though, so basically just looking for opinions...


Repository:
  rL LLVM

https://reviews.llvm.org/D61614

Files:
  llvm/include/llvm/IR/InstrTypes.h
  llvm/include/llvm/IR/Instructions.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61614.198348.patch
Type: text/x-patch
Size: 6715 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190506/5f805c10/attachment.bin>


More information about the llvm-commits mailing list