[PATCH] D61575: AMDGPU: Select VOP3 form of add

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D61575#1492375 <https://reviews.llvm.org/D61575#1492375>, @arsenm wrote:

> In D61575#1492340 <https://reviews.llvm.org/D61575#1492340>, @rampitec wrote:
>
> > I am in favor of this change in general, but can we fix folding issues before? We may have unwanted performance regressions otherwise.
>
>
> I put a lot of time into trying, but fixing all of the issues will take time and this is an important workaround. The regression in the clmem lit test from increasing the folding threshold was worse. The folding pass needs more work to track VCC accurately, and the scheduler needs work to not regress it. An alternative might be to force shrinking of the addc


We should probably wait with this change then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61575/new/

https://reviews.llvm.org/D61575