[PATCH] D61604: [InstCombine] sink FP negation of operands through select

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:347
+  }
+
   // Only handle binary operators (including two-operand getelementptr) with
----------------
spatel wrote:
> cameron.mcinally wrote:
> > Do you know what pass needs updating so that we can use the UnOp form? I could work on that next...
> > 
> > If you don't know, that's fine. I can dig it up.
> I think it's mostly within instcombine - anywhere we're implicitly or explicitly (m_BinOp) matching generic binop patterns will not match with the new fneg in IR.
Ok. @kpn already has the bulk of InstCombine covered, so I'll leave that to him. If that's okay with you, Kevin.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61604/new/

https://reviews.llvm.org/D61604