[PATCH] D61253: DWARF v5: fix directory index in the line table

Mon May 6 11:29:38 PDT 2019

dblaikie added a comment.

In D61253#1491601 <https://reviews.llvm.org/D61253#1491601>, @MaskRay wrote:

> In D61253#1491551 <https://reviews.llvm.org/D61253#1491551>, @labath wrote:
>
> > I believe the changes here are correct. What I find unfortunate is that it is not able to test this without including a debug_info info section in the object file. Which is a bit ironic given that the purpose of these changes in DWARF5 was to have a fully-standalone .debug_line section.
>
>
> The .debug_info is used by llvm-symbolizer to locate the compile unit. Without it llvm-symbolizer doesn't bother reading `.debug_line`...

Right - Pavel's point is that DWARFv5 line tables can/should be readable without debug_info, so it's unfortunate that llvm-symbolizer still reads debug_info when parsing a DWARFv5 line table, when it shouldn't have to.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61253/new/

https://reviews.llvm.org/D61253