[PATCH] D61369: [DebugInfo] Delete TypedDINodeRef

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, thanks!



================
Comment at: include/llvm/IR/DebugInfoMetadata.h:65-69
-/// FIXME: This class doesn't currently make much sense.  Previously it was a
-/// union beteen MDString (for ODR-uniqued types) and things like DIType.  To
-/// support CodeView work, it wasn't deleted outright when MDString-based type
-/// references were deleted; we'll soon need a similar concept for CodeView
-/// DITypeIndex.
----------------
dexonsmith wrote:
> I can confirm the original motivation (`MDString`-based ODR-uniquing).  @rnk, is it still thought to be useful for CodeView?
No, we don't need it, we should do this cleanup.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61369/new/

https://reviews.llvm.org/D61369