[PATCH] D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

The general approach of expanding memcmp in opt makes sense, I think.  The placement seems a little on the early side, but that's probably okay given we don't really have interesting optimizations for memcmp calls besides expanding them.

Not sure about the extra EarlyCSE invocation; it's not free.



================
Comment at: llvm/test/Other/opt-O2-pipeline.ll:141
+; CHECK-NEXT:         Merge contiguous icmps into a memcmp
+; CHECK-NEXT:         Expand memcmp() to load/stores
+; CHECK-NEXT:         Dominator Tree Construction
----------------
How hard would it be to preserve the domtree?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60318/new/

https://reviews.llvm.org/D60318