[PATCH] D61573: Add FNeg support to InstructionSimplify

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 08:29:22 PDT 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:54-56
+static Value *SimplifyUnOp(unsigned, Value *, const SimplifyQuery &, unsigned);
+static Value *SimplifyFPUnOp(unsigned, Value *, const FastMathFlags &,
+                             const SimplifyQuery &, unsigned);
----------------
Nit: we will never converge if we favor old code formatting over the current formatting spec ('camelCase'), so I'd rather have the right formatting in this patch and then update everything that's wrong with an NFC change or vice-versa. At least for the static functions, that shouldn't be too disruptive?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61573/new/

https://reviews.llvm.org/D61573





More information about the llvm-commits mailing list