[PATCH] D61595: [SIMode] Fix typo in Status constructor

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIModeRegister.cpp:47
 
-  Status(unsigned Mask, unsigned Mode) : Mask(Mask), Mode(Mode) {
+  Status(unsigned _Mask, unsigned _Mode) : Mask(_Mask), Mode(_Mode) {
     Mode &= Mask;
----------------
RKSimon wrote:
> arsenm wrote:
> > Should use something other than a leading underscore to disambiguate
> No problem, its up to you - an alternative would be to write:
> ```
> this->Mode &= this->Mask.
> ```
Trailing underscore is also OK, I just don't want to be violating the reserved names rule


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61595/new/

https://reviews.llvm.org/D61595