[PATCH] D61593: [NFC] Modernize repmovsb implementation of x86 memcpy.

[Clement Courbet via Phabricator via llvm-commits]

courbet accepted this revision.
courbet added a comment.
This revision is now accepted and ready to land.

Only nits.



================
Comment at: llvm/lib/Target/X86/X86SelectionDAGInfo.cpp:215
+
+/// Returns the best type to use with repmovs regarding alignment.
+static MVT getOptimalRepmovsType(const X86Subtarget &Subtarget,
----------------
s/regarding/depending on/


================
Comment at: llvm/lib/Target/X86/X86SelectionDAGInfo.cpp:242
+
+  /// TODO: Revisit next line: big copy with ERMSB on machr > haswell are very
+  /// efficient.
----------------
march ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61593/new/

https://reviews.llvm.org/D61593