[PATCH] D61594: [AMDGPU][test] Define local symbols used in amdgpu-relocs.s

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 07:02:38 PDT 2019


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: test/ELF/amdgpu-relocs.s:117
 
-# OBJDUMP: Contents of section .rodata:
-# OBJDUMP: 98f8ffff ffffffff
+# NM-DAG: 0000000000003008 d temp2
+# NM-DAG: 0000000000003010 B common_var0
----------------
grimar wrote:
> Do you need `-DAG`? I would expect strict order for these symbols I think.
By default, "the output shall be sorted alphabetically by symbol name" (POSIX behavior). I just deleted `-DAG`


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61594/new/

https://reviews.llvm.org/D61594





More information about the llvm-commits mailing list