[PATCH] D61595: [SIMode] Fix typo in Status constructor

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 06:50:04 PDT 2019


RKSimon created this revision.
RKSimon added reviewers: timcorringham, arsenm.
Herald added subscribers: nhaehnle, wdng, jvesely.
Herald added a project: LLVM.

As noted in https://www.viva64.com/en/b/0629/ (Snippet No. 36) and the scan-build CI reports (https://llvm.org/reports/scan-build/report-SIModeRegister.cpp-Status-1-1.html#EndPath), rL348754 <https://reviews.llvm.org/rL348754> introduced a typo due to ambiguity in the Status constructor due to argument variable names shadowing the member variable names.


Repository:
  rL LLVM

https://reviews.llvm.org/D61595

Files:
  lib/Target/AMDGPU/SIModeRegister.cpp


Index: lib/Target/AMDGPU/SIModeRegister.cpp
===================================================================
--- lib/Target/AMDGPU/SIModeRegister.cpp
+++ lib/Target/AMDGPU/SIModeRegister.cpp
@@ -44,7 +44,7 @@
 
   Status() : Mask(0), Mode(0){};
 
-  Status(unsigned Mask, unsigned Mode) : Mask(Mask), Mode(Mode) {
+  Status(unsigned _Mask, unsigned _Mode) : Mask(_Mask), Mode(_Mode) {
     Mode &= Mask;
   };
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61595.198267.patch
Type: text/x-patch
Size: 423 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190506/8679adac/attachment.bin>


More information about the llvm-commits mailing list