[PATCH] D61573: Add FNeg support to InstructionSimplify
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 6 06:47:02 PDT 2019
spatel added inline comments.
================
Comment at: llvm/test/Analysis/ConstantFolding/fneg.ll:2
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -constprop -S | FileCheck %s
+; RUN: opt < %s -instsimplify -S | FileCheck %s
----------------
cameron.mcinally wrote:
> I'm thinking that changing the pass to `-instsimplify` will save creating another file for the new xform. InstSimplify will exercise the ConstantExpr folding as well, so coverage will remain the same.
>
> Does anyone feel strongly against this?
I don't like having a test for a pass out of its named directory. That makes it hard to find.
This test can be added into:
test/Transforms/InstSimplify/floating-point-arithmetic.ll
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61573/new/
https://reviews.llvm.org/D61573
More information about the llvm-commits
mailing list