[PATCH] D61563: [ELF] Error on relocations to local undefined symbols

Mon May 6 06:47:01 PDT 2019

MaskRay marked 3 inline comments as done.
MaskRay added a comment.

This + D61583 <https://reviews.llvm.org/D61583> will give an error on the case provided in PR41693, but the error message isn't so good, so we also need D59649 <https://reviews.llvm.org/D59649> :)

================
Comment at: test/ELF/amdgpu-relocs.s:121
+# HEX-NEXT: 0x00000000 00000000 14380000 00000000 18340000
+# HEX-NEXT: 0x00000010 00000000 1c300000
----------------
grimar wrote:
> Do you know what was the point to check '.rodata'/'nonalloc' content initially?
I've moved the amdgpu-relocs.s change to D61594

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61563/new/

https://reviews.llvm.org/D61563