[PATCH] D61555: Remove BinaryOpsEnd case from ConstantFoldBinaryInstruction(...)
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 6 06:40:28 PDT 2019
spatel added a comment.
In D61555#1491319 <https://reviews.llvm.org/D61555#1491319>, @cameron.mcinally wrote:
> I'm noticing that `lib/Analysis/InstructionSimplify.cpp` has similar switches that use the default case instead of `UnaryOpsEnd` and `BinaryOpsEnd`. Is it worth taking the time to update those for compile-time warnings?
It's a nicety, but IMO not worth your time. I'd rather get FP strict/fast IR optimization and codegen improvements. :)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61555/new/
https://reviews.llvm.org/D61555
More information about the llvm-commits
mailing list