[PATCH] D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

The code changes look like what I expected, but I'd still like to hear from at least 1 other reviewer that we are not violating some high-level principle.



================
Comment at: llvm/test/Transforms/ExpandMemCmp/PowerPC/memcmpIR.ll:68-70
+; CHECK-BE-NEXT:    [[TMP17]] = call i64 @llvm.bswap.i64(i64 [[TMP15]])
+; CHECK-BE-NEXT:    [[TMP18]] = call i64 @llvm.bswap.i64(i64 [[TMP16]])
+; CHECK-BE-NEXT:    [[TMP19:%.*]] = icmp eq i64 [[TMP17]], [[TMP18]]
----------------
Why are we generating bswap for a big-endian target?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60318/new/

https://reviews.llvm.org/D60318