[PATCH] D61590: [AArch64] Default to SEH exception handling on MinGW

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: rnk, efriedma, mgrang, ssijaric.
Herald added subscribers: kristof.beyls, javed.absar.
Herald added a project: LLVM.

The SEH implementation is pretty mature at this point.


Repository:
  rL LLVM

https://reviews.llvm.org/D61590

Files:
  lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
  test/CodeGen/AArch64/dwarf-cfi.ll
  test/CodeGen/AArch64/wineh-mingw.ll


Index: test/CodeGen/AArch64/wineh-mingw.ll
===================================================================
--- test/CodeGen/AArch64/wineh-mingw.ll
+++ test/CodeGen/AArch64/wineh-mingw.ll
@@ -1,5 +1,5 @@
-; RUN: llc < %s -exception-model=wineh -mtriple=aarch64-pc-mingw32 | FileCheck %s -check-prefix=WINEH
-; RUN: llc < %s -exception-model=wineh -mtriple=aarch64-pc-mingw32 -filetype=obj | llvm-readobj -s | FileCheck %s -check-prefix=WINEH-SECTIONS
+; RUN: llc < %s -mtriple=aarch64-pc-mingw32 | FileCheck %s -check-prefix=WINEH
+; RUN: llc < %s -mtriple=aarch64-pc-mingw32 -filetype=obj | llvm-readobj -s | FileCheck %s -check-prefix=WINEH-SECTIONS
 
 ; Check emission of eh handler and handler data
 declare i32 @_d_eh_personality(i32, i32, i64, i8*, i8*)
Index: test/CodeGen/AArch64/dwarf-cfi.ll
===================================================================
--- test/CodeGen/AArch64/dwarf-cfi.ll
+++ test/CodeGen/AArch64/dwarf-cfi.ll
@@ -1,4 +1,4 @@
-; RUN: llc -mtriple aarch64-windows-gnu -filetype=asm -o - %s | FileCheck %s
+; RUN: llc -mtriple aarch64-windows-gnu -exception-model=dwarf -filetype=asm -o - %s | FileCheck %s
 
 define void @_Z1gv() personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) {
 entry:
Index: lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
===================================================================
--- lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
+++ lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
@@ -130,8 +130,6 @@
   CodePointerSize = 8;
 
   CommentString = "//";
-  ExceptionsType = ExceptionHandling::DwarfCFI;
-  // The default is dwarf, but WinEH can be enabled optionally, which requires
-  // WinEHEncodingType to be set.
+  ExceptionsType = ExceptionHandling::WinEH;
   WinEHEncodingType = WinEH::EncodingType::Itanium;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61590.198255.patch
Type: text/x-patch
Size: 1822 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190506/24acfadc/attachment.bin>