[PATCH] D61563: [ELF] Error on relocations to local undefined symbols

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Relocations.cpp:676
 static bool maybeReportUndefined(Symbol &Sym, InputSectionBase &Sec,
-                                 uint64_t Offset) {
-  if (Sym.isLocal() || !Sym.isUndefined() || Sym.isWeak())
+                                 const RelTy &Rel) {
+  if (!Sym.isUndefined() || Sym.isWeak() ||
----------------
I am also not sure it is a good idea to template this function.
Perhaps would be better to check this condition outside/or to pass the `getSymbol` value?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61563/new/

https://reviews.llvm.org/D61563