[PATCH] D61417: [NFC] Refactor TargetCallingConv so calling conventions can see which parameters are varargs

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added a comment.

Looks like a nice tidy-up, just a few style issues.



================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:3587
       CCAssignFn *AssignFn = CCAssignFnForCall(CallConv,
-                                               /*IsVarArg=*/ !Outs[i].IsFixed);
+                                               /*IsVarArg=*/ Outs[i].Flags.isVarArg());
       bool Res = AssignFn(i, ArgVT, ArgVT, CCValAssign::Full, ArgFlags, CCInfo);
----------------
This can re-use the ArgFlags variable. We can probably drop the comment now, I think the name makes this obvious now.


================
Comment at: lib/Target/Mips/MipsCCState.h:99
   // class. This doesn't stop them being used via the base class though.
+  // TODO: IsFixed is no longer an obstacle, but what about the other vectors?
   void AnalyzeCallOperands(const SmallVectorImpl<ISD::OutputArg> &Outs,
----------------
This comment is referring to code which has now been deleted, could it be re-written to just mention the current issues?


================
Comment at: lib/Target/SystemZ/SystemZCallingConv.h:60
 
   // This version of AnalyzeCallOperands in the base class is not usable
   // since we must provide a means of accessing ISD::OutputArg::IsFixed.
----------------
Another comment that should be re-worded to only refer to the current code.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61417/new/

https://reviews.llvm.org/D61417