[PATCH] D60047: [CaptureTracking] Don't let comparisons against null escape inbounds pointers

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: lib/Analysis/CaptureTracking.cpp:345
+        // means that there is no way to let a pointer escape using clever GEP
+        // hacking.
+        if (GetElementPtrInst *GEP =
----------------
jdoerfert wrote:
> I do not understand the comment above. A GEP inbounds can have any value, including 0, or am I missing a precondition here? Could you also describe why non-inbounds GEPs are not eligible?
I answered my questions in a later comment. The condition that 0 is not a valid address is missing here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60047/new/

https://reviews.llvm.org/D60047