[PATCH] D61573: Add FNeg support to InstructionSimplify

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 5 12:03:46 PDT 2019


cameron.mcinally marked an inline comment as done.
cameron.mcinally added inline comments.


================
Comment at: llvm/test/Analysis/ConstantFolding/fneg.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -constprop -S | FileCheck %s
+; RUN: opt < %s -instsimplify -S | FileCheck %s
 
----------------
I'm thinking that changing the pass to `-instsimplify` will save creating another file for the new xform. InstSimplify will exercise the ConstantExpr folding as well, so coverage will remain the same.

Does anyone feel strongly against this?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61573/new/

https://reviews.llvm.org/D61573





More information about the llvm-commits mailing list