[llvm] r359991 - Move getOpcode() call into if statement. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sun May 5 11:34:39 PDT 2019


Author: rksimon
Date: Sun May  5 11:34:38 2019
New Revision: 359991

URL: http://llvm.org/viewvc/llvm-project?rev=359991&view=rev
Log:
Move getOpcode() call into if statement. NFCI.

Avoids a cppcheck "Local variable name shadows outer variable" warning. 

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=359991&r1=359990&r2=359991&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Sun May  5 11:34:38 2019
@@ -20630,7 +20630,6 @@ SDValue X86TargetLowering::LowerSELECT(S
     CC = Cond.getOperand(0);
 
     SDValue Cmp = Cond.getOperand(1);
-    unsigned Opc = Cmp.getOpcode();
     MVT VT = Op.getSimpleValueType();
 
     bool IllegalFPCMov = false;
@@ -20639,7 +20638,7 @@ SDValue X86TargetLowering::LowerSELECT(S
       IllegalFPCMov = !hasFPCMov(cast<ConstantSDNode>(CC)->getSExtValue());
 
     if ((isX86LogicalCmp(Cmp) && !IllegalFPCMov) ||
-        Opc == X86ISD::BT) { // FIXME
+        Cmp.getOpcode() == X86ISD::BT) { // FIXME
       Cond = Cmp;
       AddTest = false;
     }




More information about the llvm-commits mailing list