[PATCH] D61564: [AMDGPU] Check MI bundles for hazards

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 5 09:47:39 PDT 2019


rampitec added a comment.

Can you add a test for one of the hazards which do not expire and have no max waitstaits? Such as hazards from smem-war-hazard.mir for example.
Granted we do not do it today, but you can write a bundle with such instructions manually.



================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:1172
+  DebugLoc DL = MBB.findDebugLoc(MI);
+  while (Count > 0) {
+    int Arg;
----------------
I do not like code duplication here. Can you call one from another?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61564/new/

https://reviews.llvm.org/D61564





More information about the llvm-commits mailing list