[PATCH] D61544: Add FNeg IR constant folding

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - although you probably want to change that 'default' in the switch statement back to match based on the comments in D61555 <https://reviews.llvm.org/D61555>.

Also (and sorry I didn't see this earlier) - the new tests for the minimal constant folding really could go in test/Analysis/ConstantFolding/ and use 'opt -constprop'. Ie, we shouldn't need to run all of instcombine or even instsimplify to see those diffs. We don't have great separation for those boundaries in several existing cases, so I'd call it a 'nice to have' change rather than a requirement.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61544/new/

https://reviews.llvm.org/D61544