[PATCH] D61236: [NFC] Add a static function to do the endian check

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 5 05:23:46 PDT 2019


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - with one minor



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6246
+  Optional<bool> IsBigEndian = isBigEndian(ByteOffsets, FirstOffset);
+  if (!IsBigEndian)
+    return SDValue();
----------------
Maybe if (!IsBigEndian.hasValue()) ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61236/new/

https://reviews.llvm.org/D61236





More information about the llvm-commits mailing list