[PATCH] D61555: Remove BinaryOpsEnd case from ConstantFoldBinaryInstruction(...)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

The type of the input is an enum type there would be a warning for a "fully covered switch default" if a default was placed in a switch the contained all enum values. The compiler assumes that the input will never take a value that isn't in the enum.  You should get this warning if you add default without removing BinaryOpsEnd. There's also a warning that gets emitted when a enum value is missing from a switch. Putting a default in the switch will suppress that latter warning.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61555/new/

https://reviews.llvm.org/D61555