[PATCH] D61555: Remove BinaryOpsEnd case from ConstantFoldBinaryInstruction(...)

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 4 17:17:16 PDT 2019

Previous message: [PATCH] D61555: Remove BinaryOpsEnd case from ConstantFoldBinaryInstruction(...)
Next message: [PATCH] D61555: Remove BinaryOpsEnd case from ConstantFoldBinaryInstruction(...)
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

craig.topper added a comment.

Doesn't using BinaryOpsEnd ensure we'll get a warning if any enum value is missing from the switch in the future? Using a plain default would suppress that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61555/new/

https://reviews.llvm.org/D61555

Previous message: [PATCH] D61555: Remove BinaryOpsEnd case from ConstantFoldBinaryInstruction(...)
Next message: [PATCH] D61555: Remove BinaryOpsEnd case from ConstantFoldBinaryInstruction(...)
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list