[PATCH] D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

I'm trusting George w/ the `MemorySSAUpdater` review.

Everything else looks good except for some commented out code I've marked.



================
Comment at: lib/Transforms/Utils/LoopSimplify.cpp:838-842
+  // auto *MSSAA = AM.getCachedResult<MemorySSAAnalysis>(F);
+  // MemorySSA *MSSA = MSSAA ? &MSSAA->getMSSA() : nullptr;
+  // std::unique_ptr<MemorySSAUpdater> MSSAU;
+  // if (MSSA)
+  // MSSAU = make_unique<MemorySSAUpdater>(MSSA);
----------------
?


================
Comment at: lib/Transforms/Utils/LoopSimplify.cpp:867
   PA.preserve<BranchProbabilityAnalysis>();
+  // PA.preserve<MemorySSAAnalysis>();
   return PA;
----------------
?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60833/new/

https://reviews.llvm.org/D60833