[PATCH] D61306: [NFC] Refactor visitIntrinsicCall so it doesn't return a const char*

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added a subscriber: reames.
sanjoy added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7542
+
   if (I.countOperandBundlesOfType(LLVMContext::OB_deopt))
     LowerCallSiteWithDeoptBundle(&I, Callee, nullptr);
----------------
courbet wrote:
> So this is not really an NFC as this is is no longer executed on `setjmp`, `longjmp`, and `clear_cache`.  Here ends my knowledge, let's find reviewers who can comment on whether this is OK or not :)
This change in behavior seems fine to me but CC @reames to be sure. 


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6511
   case Intrinsic::clear_cache:
-    return TLI.getClearCacheBuiltinName();
+    if(const char* FunctionName = TLI.getClearCacheBuiltinName())
+      lowerCallToExternalSymbol(I, FunctionName);
----------------
Needs clang-format

Also is this ever null?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61306/new/

https://reviews.llvm.org/D61306