[PATCH] D61409: [SimplifyCFG] Added condition assumption for unreachable blocks

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

In D61409#1490577 <https://reviews.llvm.org/D61409#1490577>, @xbolva00 wrote:

> Any advices about next steps for this patch?
>
> if inserted llvm.assume is a big problem and “fixing” oneUse match check is not proper solution, then this patch is dead..


In general, automatically llvm.assume much be done with extreme care, as it can pessimize optimizations. We try do this only in cases where the user as specifically indicated that there is some information relevant to optimization that is worth preserving. In this case, it might be worth doing, because the `if (x) unreachable` is the recommended "assume" pattern for use with GCC.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61409/new/

https://reviews.llvm.org/D61409