[PATCH] D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 3 17:08:20 PDT 2019
MaskRay added inline comments.
================
Comment at: llvm/tools/obj2yaml/xcoff2yaml.cpp:50
+std::error_code XCOFFDumper::dumpSymbols() {
+ std::vector<XCOFFYAML::Symbol> &Symbols = YAMLObj.Symbols;
----------------
You may want to use `Expected<...>` `Error` instead of `std::error_code`, then you can avoid conversion like `errorToErrorCode()`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61532/new/
https://reviews.llvm.org/D61532
More information about the llvm-commits
mailing list