[PATCH] D61520: Update PatternMatcher to match both FNeg(X) and FSub(+-0.0, X) in FNeg_match
Phabricator via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 3 14:18:03 PDT 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rL359936: Update PatternMatcher for FNeg (authored by mcinally, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61520?vs=198028&id=198088#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61520/new/
https://reviews.llvm.org/D61520
Files:
llvm/trunk/include/llvm/IR/PatternMatch.h
llvm/trunk/unittests/IR/PatternMatch.cpp
Index: llvm/trunk/include/llvm/IR/PatternMatch.h
===================================================================
--- llvm/trunk/include/llvm/IR/PatternMatch.h
+++ llvm/trunk/include/llvm/IR/PatternMatch.h
@@ -667,18 +667,26 @@
FNeg_match(const Op_t &Op) : X(Op) {}
template <typename OpTy> bool match(OpTy *V) {
auto *FPMO = dyn_cast<FPMathOperator>(V);
- if (!FPMO || FPMO->getOpcode() != Instruction::FSub)
- return false;
- if (FPMO->hasNoSignedZeros()) {
- // With 'nsz', any zero goes.
- if (!cstfp_pred_ty<is_any_zero_fp>().match(FPMO->getOperand(0)))
- return false;
- } else {
- // Without 'nsz', we need fsub -0.0, X exactly.
- if (!cstfp_pred_ty<is_neg_zero_fp>().match(FPMO->getOperand(0)))
- return false;
+ if (!FPMO) return false;
+
+ if (FPMO->getOpcode() == Instruction::FNeg)
+ return X.match(FPMO->getOperand(0));
+
+ if (FPMO->getOpcode() == Instruction::FSub) {
+ if (FPMO->hasNoSignedZeros()) {
+ // With 'nsz', any zero goes.
+ if (!cstfp_pred_ty<is_any_zero_fp>().match(FPMO->getOperand(0)))
+ return false;
+ } else {
+ // Without 'nsz', we need fsub -0.0, X exactly.
+ if (!cstfp_pred_ty<is_neg_zero_fp>().match(FPMO->getOperand(0)))
+ return false;
+ }
+
+ return X.match(FPMO->getOperand(1));
}
- return X.match(FPMO->getOperand(1));
+
+ return false;
}
};
Index: llvm/trunk/unittests/IR/PatternMatch.cpp
===================================================================
--- llvm/trunk/unittests/IR/PatternMatch.cpp
+++ llvm/trunk/unittests/IR/PatternMatch.cpp
@@ -589,6 +589,35 @@
EXPECT_TRUE(match(VectorZeroUndef, m_AnyZeroFP()));
}
+TEST_F(PatternMatchTest, FloatingPointFNeg) {
+ Type *FltTy = IRB.getFloatTy();
+ Value *One = ConstantFP::get(FltTy, 1.0);
+ Value *Z = ConstantFP::get(FltTy, 0.0);
+ Value *NZ = ConstantFP::get(FltTy, -0.0);
+ Value *V = IRB.CreateFNeg(One);
+ Value *V1 = IRB.CreateFSub(NZ, One);
+ Value *V2 = IRB.CreateFSub(Z, One);
+ Value *V3 = IRB.CreateFAdd(NZ, One);
+ Value *Match;
+
+ // Test FNeg(1.0)
+ EXPECT_TRUE(match(V, m_FNeg(m_Value(Match))));
+ EXPECT_EQ(One, Match);
+
+ // Test FSub(-0.0, 1.0)
+ EXPECT_TRUE(match(V1, m_FNeg(m_Value(Match))));
+ EXPECT_EQ(One, Match);
+
+ // Test FSub(0.0, 1.0)
+ EXPECT_FALSE(match(V2, m_FNeg(m_Value(Match))));
+ cast<Instruction>(V2)->setHasNoSignedZeros(true);
+ EXPECT_TRUE(match(V2, m_FNeg(m_Value(Match))));
+ EXPECT_EQ(One, Match);
+
+ // Test FAdd(-0.0, 1.0)
+ EXPECT_FALSE(match(V3, m_FNeg(m_Value(Match))));
+}
+
template <typename T> struct MutableConstTest : PatternMatchTest { };
typedef ::testing::Types<std::tuple<Value*, Instruction*>,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61520.198088.patch
Type: text/x-patch
Size: 2751 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190503/a1f9d974/attachment.bin>
More information about the llvm-commits
mailing list