[PATCH] D61097: [Sema] Emit warning for visibility attribute on internal-linkage declaration

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 3 13:17:31 PDT 2019


scott.linder added a comment.

Richard Smith on cfe-dev pointed out some cases where this patch is incorrect, stemming from trying to calculate the linkage too early; the warning will either have to work without the use of `isExternallyVisible` or will have to be emitted later. This was reverted in `r359858` for now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61097/new/

https://reviews.llvm.org/D61097





More information about the llvm-commits mailing list