[PATCH] D61390: [CodeGen] Add lround/llround builtins

Adhemerval Zanella via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 3 12:43:54 PDT 2019


zatrazz updated this revision to Diff 198065.
zatrazz added a comment.

In fact, it turned out that indexing the new lround/llround based on
input argument didn't really make it correctly handled as an expanded
operation. I will dig into exactly why backend is not selecting correctly
based on input argument, so I change it back to previous indexing by
return type.

I have clean up the testscase to remove duplicated entries and add a
x86_64 one so the code path to lower to libcalls will still be stressed
(since the idea for AArch64 is optimize to specific instructions).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61390/new/

https://reviews.llvm.org/D61390

Files:
  llvm/docs/LangRef.rst
  llvm/include/llvm/CodeGen/ISDOpcodes.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/include/llvm/IR/RuntimeLibcalls.def
  llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
  llvm/lib/CodeGen/TargetLoweringBase.cpp
  llvm/test/CodeGen/AArch64/llround-conv.ll
  llvm/test/CodeGen/AArch64/lround-conv.ll
  llvm/test/CodeGen/ARM/llround-conv.ll
  llvm/test/CodeGen/ARM/lround-conv.ll
  llvm/test/CodeGen/X86/llround-conv.ll
  llvm/test/CodeGen/X86/lround-conv.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61390.198065.patch
Type: text/x-patch
Size: 22338 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190503/2ad55148/attachment.bin>


More information about the llvm-commits mailing list