[PATCH] D60982: [SimplifyCFG] Use lookup tables when they are more space efficient or a huge speed win.

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 3 07:50:49 PDT 2019


jmolloy requested changes to this revision.
jmolloy added a comment.
This revision now requires changes to proceed.

Looking much better. I think the TTI hook could be described better.



================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:581
+  /// should be turned in to a lookup table for this target.
+  bool shouldBuildLookupTable(size_t TableSize, uint32_t NumCases,
+                              unsigned CaseSize, bool HasOptSize) const;
----------------
What is the TableSize, and what is the CaseSize? In particular why would TableSize ever be different from NumCases?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60982/new/

https://reviews.llvm.org/D60982





More information about the llvm-commits mailing list