[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 3 07:17:19 PDT 2019


andreadb added a comment.

Overall, the patch looks good to me.

I also don't think that those tied operands should have had the kill flag set. But then, I don't know how important is to accurately preserve kill flags in FixupLEAs; my understanding is that FixupLEAs runs quite late in the codegen pipeline (since it is a pre-emit pass). So, I don't know if passes running after it still try to check for the presence of those flags.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61472/new/

https://reviews.llvm.org/D61472





More information about the llvm-commits mailing list