[PATCH] D61493: AMDGPU/MC: Add .amdgpu_lds directive

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:206
+void AMDGPUTargetAsmStreamer::emitAMDGPULDS(MCSymbol *Symbol, unsigned Align) {
+  OS << "\t.amdgpu_lds " << Symbol->getName() << ", " << Align << "\n";
+}
----------------
Single quotes around '\n'


================
Comment at: test/MC/AMDGPU/elf-lds.s:8-11
+        s_mov_b32 s0, lds0 at abs32@lo
+	v_lshl_add_u32 v0, v0, 2, s0
+	ds_read2_b32 v[1:2], v0 offset1:1
+	s_endpgm
----------------
Weird indentation mix


================
Comment at: test/MC/AMDGPU/elf-lds.s:17
+	.size lds0, 192
+	.amdgpu_lds lds0, 16
+
----------------
Should add some more cases to stress the parser with no and extra whitespace. Also for the error cases with missing/invalid alignment values


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61493/new/

https://reviews.llvm.org/D61493