[PATCH] D61020: [ARM][ParallelDSP] Relax alias checks

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:385
+  // dominating Load.
+  auto CheckRAWDeps = [&](LoadInst *Base, LoadInst *Offset) {
+    if (CheckMemDeps(Base, Offset, RawDeps))
----------------
Can you elaborate on what this function is doing? My first reaction would be, given that we are looking at 2 loads, how come are we looking for RAW dependencies? Perhaps the function name is a bit misleading?


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:398
+  // WAR dependence.
+  auto CheckWARDeps = [&](LoadInst *Base, LoadInst *Offset) {
+    if (CheckMemDeps(Base, Offset, WarDeps))
----------------
Functions CheckRAWDeps and CheckWARDeps are the same, just the order of Base and Offset are different, and whether WarDeps or RawDeps are queried, but this could be passed in as an argument. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61020/new/

https://reviews.llvm.org/D61020