[PATCH] D61037: [WebAssembly] Implement ReplaceNodeResults to fix a SIMD crash

[Thomas Lively via Phabricator via llvm-commits]

tlively marked 2 inline comments as done.
tlively added a comment.

`DAGTypeLegalizer` calls `ReplaceNodeResults` whenever `CustomLowerNode` is called and its parameter `LegalizeResult` is true or when `CustomWidenLowerNode` is called. So basically it is the same as `LowerOperation` except that it is meant to focus on legalizing the result type rather than simply transforming the operation. There is even a TODO on `LowerOperationWrapper`, `  /// TODO: Consider merging with ReplaceNodeResults.`.



================
Comment at: llvm/test/CodeGen/WebAssembly/simd-illegal-signext.ll:8
+; ReplaceNodeResults to resolve, but the default implementation is to
+; abort.
+
----------------
aheejin wrote:
> Nit: Can we make it wrap to 80 cols bit more? It currently looks kinda random
I would have to break up the very long `WebAssemblyTargetLowering::ReplaceNodeResults` to make the wrapping prettier. I think it's more valuable to keep the name so the reader knows exactly what was fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61037/new/

https://reviews.llvm.org/D61037