[PATCH] D61461: When removing inalloca, convert to static alloca

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 16:22:51 PDT 2019


inglorion added a comment.

I think Eli raises a good point, and I'm inclined to just say "if the alloca (before hoisting) is not in the same BB as the call, don't hoist it". That avoids changing the stack behavior of the code. It also means we miss out on an optimization, but it's an optimization that we're not performing today anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61461/new/

https://reviews.llvm.org/D61461





More information about the llvm-commits mailing list