[PATCH] D61411: [SelectionDAG] Expand ADD/SUBCARRY
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 2 15:24:10 PDT 2019
efriedma added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3293
+ SDValue CarryExt =
+ DAG.getZeroExtendInReg(DAG.getZExtOrTrunc(Carry, dl, VT), dl, VT);
+ SDValue Sum2 = DAG.getNode(Op, dl, VT, Sum, CarryExt);
----------------
The VT argument for getZeroExtendInReg is the mask, so should be MVT::i1. The way it's written, the getZeroExtendInReg does nothing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61411/new/
https://reviews.llvm.org/D61411
More information about the llvm-commits
mailing list