[PATCH] D61397: [DAGCombiner] Limit number of nodes to explore, to avoid quadratic compile time.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D61397#1487955 <https://reviews.llvm.org/D61397#1487955>, @niravd wrote:

> Notes inline, but I think the majority of the compile time improvements come from keepign TokenFactor operand counts bounded. This should be changed to do reflect that.


Thanks for taking a look. Yep I think that might be the case. I'll verify that tomorrow.

> That said, I think rewriting the "CanMergeStoresTo" to "GetMaximumMergedStoreSize" and using that as a first-order filter on nodes to consider like was discussed in D60133 <https://reviews.llvm.org/D60133> should be done before any heuristic restrictions (including TokenFactor operand count limits) should be considered as it causes no code generation degradation, only compile time improvements.

I will get back to D60133 <https://reviews.llvm.org/D60133> soon as well! Unfortunately it did not yield any improvements for the case I am looking at.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61397/new/

https://reviews.llvm.org/D61397