[PATCH] D61143: [gn] Support for building libc++

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/utils/gn/secondary/libcxx/include/BUILD.gn:74
+    "__functional_base_03",
+    "__hash_table",
+    "__libcpp_version",
----------------
thakis wrote:
> Should we make the sync script handle files without extensions too?
Probably although I'd leave that as a separate change because that might affect other files as well.


================
Comment at: llvm/utils/gn/secondary/libcxx/src/BUILD.gn:12
+  # Build libc++ as a static library.
+  libcxx_enable_static = true
+
----------------
thakis wrote:
> Are both of these enabled by default in cmake? (shared and static, that is)
Yes


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61143/new/

https://reviews.llvm.org/D61143