[PATCH] D61420: [ELF] --plugin-opt=thinlto-index-only: create empty index even if all bitcode files are lazy

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 06:46:43 PDT 2019


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM with one suggestion below.



================
Comment at: ELF/LTO.cpp:217
+// distributed build system that depends on that behavior.
+void elf::thinLTOCreateEmptyIndex() {
+  for (LazyObjFile *F : LazyObjFiles) {
----------------
Suggest renaming to thinLTOCreateEmptyIndexFiles for clarity.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61420/new/

https://reviews.llvm.org/D61420





More information about the llvm-commits mailing list