[PATCH] D61331: [SelectionDAG] remove constant folding limitations based on FP exceptions

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 06:40:18 PDT 2019


spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:4233
       if (fs == APFloat::opOK || fs == APFloat::opInexact)
         return getConstantFP(V, DL, VT);
       break;
----------------
cameron.mcinally wrote:
> Happened to stumble across more of these exception checks. Just a heads up...
Thanks. Also, I just noticed that we do not constant fold the FMA intrinsic in IR. Haven't looked at the unary ops in IR yet, but I'll try to make this consistent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61331/new/

https://reviews.llvm.org/D61331





More information about the llvm-commits mailing list