[PATCH] D61343: [llvm-objcopy] Cache gnu_debuglink's target CRC

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:508
+    // finalize the CRC32 value. It also doesn't negate the initial CRC32 value
+    // but it starts by default at 0xFFFFFFFF which is the complement of zero.
+    Config.GnuDebugLinkCRC32 = ~CRC.getCRC();
----------------
Since you are moving the comment, may I ask you to delete `It also doesn't negate the initial CRC32 value but it starts by default at 0xFFFFFFFF which is the complement of zero.` This sentence if verbose and doesn't appear to help a casual reader understand the rationale.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61343/new/

https://reviews.llvm.org/D61343