[PATCH] D51160: Adjust MIScheduler to use ProcResource counts

[Momchil Velikov via Phabricator via llvm-commits]

chill marked 4 inline comments as done.
chill added a comment.

In D51160#1442763 <https://reviews.llvm.org/D51160#1442763>, @fhahn wrote:

> Do you have any benchmark data you could share with this patch? I am curious what the impact is and if there are any  regressions.


No, I'm sorry, I don't have publishable benchmark results at the moment.



================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:2036
       unsigned Cycles = PE.Cycles;
-      unsigned NRCycle = getNextResourceCycle(ResIdx, Cycles);
+      unsigned NRCycle, InstanceID;
+      std::tie(NRCycle, InstanceID) =
----------------
fhahn wrote:
> InstanceID unused?
Yes, it's unused, here and in one more place we care only for the cycle number.


================
Comment at: llvm/test/CodeGen/ARM/proc-resource-sched.ll:15
+
+; Cortex-R52 model describes it as dual-issue with two integer ALUs
+; It should be able to issue the two additions in the same cycle.
----------------
fhahn wrote:
> The function is quite small, can you check the full schedule?
I'm not sure what do you mean. The test tests the difference in the internal state of the scheduler, which does not necesarily results in different schedule. Perhaps I can make a bigger test case, but I'd rather not do it as it'll have the tendency to break with unrelated scheduler changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51160/new/

https://reviews.llvm.org/D51160